On Fri, Dec 23, 2011 at 06:39:26PM +0100, Julia Lawall wrote: > Error handling code following a kzalloc should free the allocated data. At > this point, chip has been allocated and some fields have been initialized, > but it has not been stored anywhere, so it should be freed before leaving > the function. With this and probably a bunch of the other corrections in this series a conversion to devm_kazlloc() would be a more complete fix as it prevents people introducing similar missing cleanup paths in future. Not sure if spatch can generate that automatically though... -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html