From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Thu, 15 Dec 2011 14:05:10 +0300
> We should only dereference the pointer if it's valid, not the other way
> round.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
It's nice to see how thoroughly this code has been tested, sigh...
Applied, thanks a lot Dan.
> diff --git a/net/ipv4/tcp_memcontrol.c b/net/ipv4/tcp_memcontrol.c
> index 171d7b6..7fed04f 100644
> --- a/net/ipv4/tcp_memcontrol.c
> +++ b/net/ipv4/tcp_memcontrol.c
> @@ -44,7 +44,7 @@ static inline struct tcp_memcontrol *tcp_from_cgproto(struct cg_proto *cg_proto)
>
> static void memcg_tcp_enter_memory_pressure(struct sock *sk)
> {
> - if (!sk->sk_cgrp->memory_pressure)
> + if (sk->sk_cgrp->memory_pressure)
> *sk->sk_cgrp->memory_pressure = 1;
> }
> EXPORT_SYMBOL(memcg_tcp_enter_memory_pressure);
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
