Re: [patch] drm/ttm: fix condition (and vs or)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




----- Original Message -----
> From: "Konrad Rzeszutek Wilk" <konrad.wilk@xxxxxxxxxx>
> To: "Jerome Glisse" <j.glisse@xxxxxxxxx>
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx, "Jerome Glisse" <jglisse@xxxxxxxxxx>, kernel-janitors@xxxxxxxxxxxxxxx, "Thomas
> Hellstrom" <thellstrom@xxxxxxxxxx>, "Dan Carpenter" <dan.carpenter@xxxxxxxxxx>
> Sent: Thursday, 8 December, 2011 4:53:34 PM
> Subject: Re: [patch] drm/ttm: fix condition (and vs or)
> 
> On Thu, Dec 08, 2011 at 10:34:00AM -0500, Jerome Glisse wrote:
> > On Thu, Dec 08, 2011 at 09:50:54AM +0300, Dan Carpenter wrote:
> > > The "if (!p && !p->dev)" condition isn't right because || was
> > > intended
> > > instead of &&.  But actually, "p" is the list cursor and so it's
> > > always
> 
> Duh!
> > > non-NULL and we can just remove that bit.  We can remove the
> > > another
> > > similar check as well.
> > > 
> > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> > Reviewed-by: Jerome Glisse <jglisse@xxxxxxxxxx>
> 
> And Acked-by me.
> 
> Jerome, since you have the patches (And are thinking to send a GIT
> PULL
> to Dave) in your tree, could you include this patch in your queue?
> 

I've taken the TTM changes into drm-next already, just reviewing the radeon stuff.

But if that appeared on top in Jerome's tree I can steal it.

Dave.
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux