The return value of snprintf() is the number of bytes which would
have been copied if there was enough space, but we want the number of
bytes actually copied. The scnprintf() function does this.
Also in theory, a %u can take take 10 digits so we may as well make
the buffer larger as well.
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
---
v2: I didn't know about the scnprintf() function before. Thanks
Johannes.
diff --git a/drivers/net/wireless/ath/ath6kl/debug.c b/drivers/net/wireless/ath/ath6kl/debug.c
index 9eff0d0..eb808b4 100644
--- a/drivers/net/wireless/ath/ath6kl/debug.c
+++ b/drivers/net/wireless/ath/ath6kl/debug.c
@@ -1551,10 +1551,10 @@ static ssize_t ath6kl_listen_int_read(struct file *file,
size_t count, loff_t *ppos)
{
struct ath6kl *ar = file->private_data;
- char buf[16];
+ char buf[32];
int len;
- len = snprintf(buf, sizeof(buf), "%u %u\n", ar->listen_intvl_t,
+ len = scnprintf(buf, sizeof(buf), "%u %u\n", ar->listen_intvl_t,
ar->listen_intvl_b);
return simple_read_from_buffer(user_buf, count, ppos, buf, len);
Attachment:
signature.asc
Description: Digital signature
