Am 21.11.2011 15:50, schrieb Dan Carpenter: > We can't call mpi_free() on the elements if the first kzalloc() fails. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > diff --git a/lib/mpi/mpi-mpow.c b/lib/mpi/mpi-mpow.c > index 4cc7593..7328d0d 100644 > --- a/lib/mpi/mpi-mpow.c > +++ b/lib/mpi/mpi-mpow.c > @@ -73,7 +73,7 @@ int mpi_mulpowm(MPI res, MPI *basearray, MPI *exparray, MPI m) > > G = kzalloc((1 << k) * sizeof *G, GFP_KERNEL); > if (!G) > - goto nomem; > + goto err_out; > > /* and calculate */ > tmp = mpi_alloc(mpi_get_nlimbs(m) + 1); > @@ -129,5 +129,6 @@ nomem: > for (i = 0; i < (1 << k); i++) > mpi_free(G[i]); > kfree(G); > +err_out: > return rc; > } the patch is ok but is there any reason *not* to use a more nice name that 'G' something more descriptive perhaps ? re, wh -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
