Hi Dan, > The "tmp" variable here is used to store the result of cpu_to_le16() > so it should be a u16 instead of an int. We want the high bits set > and the current code works on little endian systems but not on big > endian systems. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Looks OK by me, unless you want to make sparse with __CHECK_ENDIAN__ shut up, then you should use __le16 ;-) Acked-by: Sjur Brændeland <sjur.brandeland@xxxxxxxxxxxxxx> Regards, Sjur -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html