Re: [PATCH] drivers/staging/vt6656/iwctl.c: Remove PRINT_K macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2011/11/7, Dan Carpenter <dan.carpenter@xxxxxxxxxx>:
> On Mon, Nov 07, 2011 at 07:27:52AM -0300, Marcos Souza wrote:
>> 2011/11/7, Dan Carpenter <dan.carpenter@xxxxxxxxxx>:
>> > Hi Marcos,
>> >
>> > This should be sent to devel@xxxxxxxxxxxxxxxxxxxx as well.
>> On copy this time
>> > DBG_PRT() is just as bad as PRINT_K().  The first example in
>> > iwctl_siwscan() should be either pr_debug() or dev_dbg().  Also the
>> > message itself is wrong.
>> So, I'll send patches to change all these print_k and dbg_prt to dev_dbg
>
> It's not as simple as doing a sed over the driver.  You have to look
> at each one and decide what it should be.  I only looked at the first
> PRINT_K() and said specific one should be a pr_debug() not that all
> of them should.
Sorry, I think I was not so clear as I wanted. I'll analyse all the
uses of dbg_prt and print_k, and change these as they can be assigned
to pr_debug and dev_dbg.
> regards,
> dan carpenter
>
>


-- 
Marcos Paulo de Souza

*Porque uma vida sem desafios é uma vida sem razão.*
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux