On Sat, 29 Oct 2011, Julia Lawall wrote: > It is not possible to take the lock in device if device is NULL. > The mutex_lock is thus moved after the NULL test. New error handling > labels are added at the end to differentiate between the cases where > different sets of locks should be unlocks, and between whether or not > reader should be freed (only on error). > > The semantic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @r@ > expression E, E1; > identifier f; > statement S1,S2,S3; > @@ > > if (E == NULL) > { > ... when != if (E == NULL || ...) S1 else S2 > when != E = E1 > *E->f > ... when any > return ...; > } > else S3 > // </smpl> > > Signed-off-by: Julia Lawall <julia@xxxxxxx> Applied, thank you. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
