Re: [patch] [ALSA] hwdep: silence integer overflow warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Am 28.10.2011 08:45, schrieb Dan Carpenter:
> On Thu, Oct 20, 2011 at 09:39:23AM +0200, walter harms wrote:
>> I am not sure how SNDRV_MINOR_HWDEPS is used further
> 
> Either device = SNDRV_MINOR_HWDEPS or device = SNDRV_MINOR_HWDEPS + 1
> are fine (equivalent) but it's a fair point.  Your version is nicer.
> 
> I'll redo the patch.
> 

An other question is:
Should the user be informed that the device is modified ?
The Problem i see is that a user parameter is silently modified
and buggy code will come through.

re,
 wh
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux