Hi Dan, > -----Original Message----- > From: Dan Carpenter [mailto:dan.carpenter@xxxxxxxxxx] > Sent: Monday, October 17, 2011 11:15 PM > To: Bing Zhao > Cc: John W. Linville; linux-wireless@xxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx > Subject: [patch 3/4] mwifiex: prevent corruption instead of just warning > > We may as well put a return here instead of just printing a warning > message and then corrupting memory. The caller doesn't check the > return code. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > diff --git a/drivers/net/wireless/mwifiex/pcie.c b/drivers/net/wireless/mwifiex/pcie.c > index d12d440..40b154d 100644 > --- a/drivers/net/wireless/mwifiex/pcie.c > +++ b/drivers/net/wireless/mwifiex/pcie.c > @@ -1228,9 +1228,11 @@ static int mwifiex_pcie_event_complete(struct mwifiex_adapter *adapter, > if (!skb) > return 0; > > - if (rdptr >= MWIFIEX_MAX_EVT_BD) > + if (rdptr >= MWIFIEX_MAX_EVT_BD) { > dev_err(adapter->dev, "event_complete: Invalid rdptr 0x%x\n", > rdptr); > + return -EINVAL; Instead of returning directly, we should set the error code and go through the error handling: ret = -EINVAL; goto done; Could you please resend v2? Thanks, Bing > + } > > /* Read the event ring write pointer set by firmware */ > if (mwifiex_read_reg(adapter, REG_EVTBD_WRPTR, &wrptr)) { -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
