On 18.10.11 08:24, Dan Carpenter wrote:
! has higher precedence than>= and since neither 0 nor 1 are greater
than 8 the condition is always false.
Sure. The call in question actually not more than a sanity check, as
lower layers will never call this function with an invalid substream number.
Thanks for spotting this.
Signed-off-by: Dan Carpenter<dan.carpenter@xxxxxxxxxx>
Acked-by: Daniel Mack <zonque@xxxxxxxxx>
diff --git a/drivers/usb/gadget/f_midi.c b/drivers/usb/gadget/f_midi.c
index 44858dc..ef1bc7a 100644
--- a/drivers/usb/gadget/f_midi.c
+++ b/drivers/usb/gadget/f_midi.c
@@ -644,7 +644,7 @@ static int f_midi_out_open(struct snd_rawmidi_substream *substream)
{
struct f_midi *midi = substream->rmidi->private_data;
- if (!substream->number>= MAX_PORTS)
+ if (substream->number>= MAX_PORTS)
return -EINVAL;
VDBG(midi, "%s()\n", __func__);
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
