RE: [patch] RDMA/nes: silence compiler warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: roland@xxxxxxxxxxxxxxx [mailto:roland@xxxxxxxxxxxxxxx] On Behalf
> Of Roland Dreier
> Sent: Monday, October 17, 2011 1:15 PM
> To: Dan Carpenter
> Cc: Latif, Faisal; Hefty, Sean; Hal Rosenstock; linux-
> rdma@xxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx
> Subject: Re: [patch] RDMA/nes: silence compiler warning
> 
> On Mon, Oct 17, 2011 at 12:28 AM, Dan Carpenter
> <dan.carpenter@xxxxxxxxxx> wrote:
> >        nes_debug(NES_DBG_CM, "QP%u, Destination IP = 0x%08X:0x%04X,
> local = "
> >                  "0x%08X:0x%04X, rcv_nxt=0x%08X, snd_nxt=0x%08X, mpa
> + "
> > -                 "private data length=%zu.\n", nesqp->hwqp.qp_id,
> > +                 "private data length=%d.\n", nesqp->hwqp.qp_id,
> >                  ntohl(cm_id->remote_addr.sin_addr.s_addr),
> >                  ntohs(cm_id->remote_addr.sin_port),
> >                  ntohl(cm_id->local_addr.sin_addr.s_addr),
> 
> By the way, could this debug message be using %pI4 instead of %08X to
> print IP addresses?
> 
>  - R.

Yes, We should have used %pI4 for this also.

Thanks
Faisal

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux