On Mon, Oct 17, 2011 at 10:41:17AM +0300, Dan Carpenter wrote: > This should be a bitwise negate here. It silences a Sparse warning: > fs/nfsd/nfs4xdr.c:693:16: warning: dubious: x & !y Whoops, thanks for catching that! Applying for 3.2.--b. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c > index 2cab33c..645a0a9 100644 > --- a/fs/nfsd/nfs4xdr.c > +++ b/fs/nfsd/nfs4xdr.c > @@ -690,7 +690,7 @@ static __be32 nfsd4_decode_share_deny(struct nfsd4_compoundargs *argp, u32 *x) > READ_BUF(4); > READ32(*x); > /* Note: unlinke access bits, deny bits may be zero. */ > - if (*x & !NFS4_SHARE_DENY_BOTH) > + if (*x & ~NFS4_SHARE_DENY_BOTH) > return nfserr_bad_xdr; > return nfs_ok; > xdr_error: -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
