Agreed. Thanks, Achim -----Original Message----- From: Dan Carpenter [mailto:dan.carpenter@xxxxxxxxxx] Sent: Donnerstag, 6. Oktober 2011 16:31 To: Achim Leubner Cc: Rolf Eike Beer; Adaptec OEM Raid Solutions; James E.J. Bottomley; linux-scsi@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx Subject: Re: [patch] [SCSI] aacraid: use lower snprintf() limit On Wed, Oct 05, 2011 at 05:19:12AM -0700, Achim Leubner wrote: > Looks good so far. But do we really need the last two lines? > > + if (len > 16) > > + len = 16; > snprintf() returns the number of characters that it _would_ have copied if it had space. We want to return the number of bytes actually copied. Again, the snprintf() values do fit so this change doesn't actually make any difference. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
