On Wed, 21 Sep 2011 06:55:31 -0700, Guenter Roeck wrote: > On Wed, Sep 21, 2011 at 07:41:29AM -0400, Marc Hulsman wrote: > > Hi Chris, > > > > (lm-sensors CC-ed) > > > > On Thursday 15 September 2011 08:30:46 Chris Peterson wrote: > > > gcc -Wextra warns "‘register’ is not at beginning of declaration" because > > > the compiler thinks the parameter has been marked as a 'register' > > > variable, but the function prototype intended to name the parameter > > > "register" (which is a reserved keyword). > > > > > > Signed-off-by: Chris Peterson <cpeterso@xxxxxxxxxxxx> > > > --- > > > drivers/hwmon/w83791d.c | 4 ++-- > > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/hwmon/w83791d.c b/drivers/hwmon/w83791d.c > > > index 17cf1ab..8c2844e 100644 > > > --- a/drivers/hwmon/w83791d.c > > > +++ b/drivers/hwmon/w83791d.c > > > @@ -329,8 +329,8 @@ static int w83791d_detect(struct i2c_client *client, > > > struct i2c_board_info *info); > > > static int w83791d_remove(struct i2c_client *client); > > > > > > -static int w83791d_read(struct i2c_client *client, u8 register); > > > -static int w83791d_write(struct i2c_client *client, u8 register, u8 value); > > > +static int w83791d_read(struct i2c_client *client, u8 reg); > > > +static int w83791d_write(struct i2c_client *client, u8 reg, u8 value); > > > static struct w83791d_data *w83791d_update_device(struct device *dev); > > > > > > #ifdef DEBUG > > > > Thanks! Patch looks (and works) fine. > > > > Acked-by: Marc Hulsman <m.hulsman@xxxxxxxxxx> > > > > Guenter or Jean, can you pick up this patch? Original mail was not posted to lm_sensors, > > but can be found here: > > http://www.spinics.net/lists/linux-kernel-janitors/msg09690.html > > or see below for a copy of the patch without the >. > > Applied. I thought I had fixed all these years ago, but apparently I missed w83791d :( Thanks Marc and Guenter. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
