Re: [patch] suspend: off by one in pm_suspend()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday, September 20, 2011, Dan Carpenter wrote:
> In enter_state() we use "state" as an offset for the pm_states[]
> array.  The pm_states[] array only has PM_SUSPEND_MAX elements so
> this test is off by one.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Applied to linux-pm/linux-next, will be pushed for 3.2.

Thanks,
Rafael


> diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c
> index 1d58583..4953dc0 100644
> --- a/kernel/power/suspend.c
> +++ b/kernel/power/suspend.c
> @@ -321,7 +321,7 @@ int enter_state(suspend_state_t state)
>  int pm_suspend(suspend_state_t state)
>  {
>  	int ret;
> -	if (state > PM_SUSPEND_ON && state <= PM_SUSPEND_MAX) {
> +	if (state > PM_SUSPEND_ON && state < PM_SUSPEND_MAX) {
>  		ret = enter_state(state);
>  		if (ret) {
>  			suspend_stats.fail++;
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux