On Fri, Sep 02, 2011 at 11:40:23AM +0200, Sjur Brændeland wrote: > Thank you for your patch. > When reviewing this I found another potential memory leak as well. > If cffrml_create fails, we might be leaking the phy_driver. > So perhaps you could do kfree(phy_driver) in out_err: as well, while > you are at it? > Good point. A kfree(phy_driver) would fix the leak. But why does cfserl_create() return &this->layer; instead of just "return this;" Their equivalent now, but if you change the cfserl struct it will break the kfree(). I'll be travelling for a while, so I may be out of reach until Wednessday. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
