The patch seem to be fine. Please consider this patch as Acked-by: "Nandigama, Nagalakshmi" <Nagalakshmi.Nandigama@xxxxxxx> Regards, Nagalakshmi -----Original Message----- From: Julia Lawall [mailto:julia@xxxxxxx] Sent: Wednesday, August 10, 2011 5:02 PM To: James E.J. Bottomley Cc: kernel-janitors@xxxxxxxxxxxxxxx; Desai, Kashyap; James Bottomley; linux-scsi@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx Subject: [PATCH] drivers/scsi/mpt2sas/mpt2sas_transport.c: add missing sas_phy_free From: Julia Lawall <julia@xxxxxxx> In each case, sas_phy_add has not yet been successfully applied, so use sas_phy_free to free phy. Signed-off-by: Julia Lawall <julia@xxxxxxx> --- drivers/scsi/mpt2sas/mpt2sas_transport.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/mpt2sas/mpt2sas_transport.c b/drivers/scsi/mpt2sas/mpt2sas_transport.c index 15c7980..762f05e 100644 --- a/drivers/scsi/mpt2sas/mpt2sas_transport.c +++ b/drivers/scsi/mpt2sas/mpt2sas_transport.c @@ -857,6 +857,7 @@ mpt2sas_transport_add_host_phy(struct MPT2SAS_ADAPTER *ioc, struct _sas_phy &mpt2sas_phy->identify))) { printk(MPT2SAS_ERR_FMT "failure at %s:%d/%s()!\n", ioc->name, __FILE__, __LINE__, __func__); + sas_phy_free(phy); return -1; } phy->identify = mpt2sas_phy->identify; @@ -923,6 +924,7 @@ mpt2sas_transport_add_expander_phy(struct MPT2SAS_ADAPTER *ioc, struct _sas_phy &mpt2sas_phy->identify))) { printk(MPT2SAS_ERR_FMT "failure at %s:%d/%s()!\n", ioc->name, __FILE__, __LINE__, __func__); + sas_phy_free(phy); return -1; } phy->identify = mpt2sas_phy->identify; -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
