Re: [patch 1/2 -next] hid-lg4ff: silence sparse complaint

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 18 Aug 2011, Dan Carpenter wrote:

> Sparse complains that:
> drivers/hid/hid-lg4ff.c:288:44: warning: Using plain integer as NULL pointer
> drivers/hid/hid-lg4ff.c:311:44: warning: Using plain integer as NULL pointer
> 
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
> 
> diff --git a/drivers/hid/hid-lg4ff.c b/drivers/hid/hid-lg4ff.c
> index dc38c2d..2d8762d 100644
> --- a/drivers/hid/hid-lg4ff.c
> +++ b/drivers/hid/hid-lg4ff.c
> @@ -285,7 +285,7 @@ static void hid_lg4ff_switch_native(struct hid_device *hid, const struct lg4ff_n
>  /* Read current range and display it in terminal */
>  static ssize_t lg4ff_range_show(struct device *dev, struct device_attribute *attr, char *buf)
>  {
> -	struct lg4ff_device_entry *entry = 0;
> +	struct lg4ff_device_entry *uninitialized_var(entry);
>  	struct list_head *h;
>  	struct hid_device *hid = to_hid_device(dev);
>  	size_t count;
> @@ -308,7 +308,7 @@ static ssize_t lg4ff_range_show(struct device *dev, struct device_attribute *att
>   * according to the type of the wheel */
>  static ssize_t lg4ff_range_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t count)
>  {
> -	struct lg4ff_device_entry *entry = 0;
> +	struct lg4ff_device_entry *uninitialized_var(entry);
>  	struct list_head *h;
>  	struct hid_device *hid = to_hid_device(dev);
>  	__u16 range = simple_strtoul(buf, NULL, 10);

Applied.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux