this patch is now in the fixes branch of ocfs2.git. On Sat, Jul 09, 2011 at 06:04:39PM +0200, Julia Lawall wrote: > From: Julia Lawall <julia@xxxxxxx> > > Memory allocated using kmem_cache_zalloc should be freed using > kmem_cache_free, not kfree. > > The semantic patch that fixes this problem is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > expression x,e,e1,e2; > @@ > > x = kmem_cache_zalloc(e1,e2) > ... when != x = e > ?-kfree(x) > +kmem_cache_free(e1,x) > // </smpl> > > Signed-off-by: Julia Lawall <julia@xxxxxxx> > > --- > fs/ocfs2/dlm/dlmlock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -u -p a/fs/ocfs2/dlm/dlmlock.c b/fs/ocfs2/dlm/dlmlock.c > --- a/fs/ocfs2/dlm/dlmlock.c > +++ b/fs/ocfs2/dlm/dlmlock.c > @@ -440,7 +440,7 @@ struct dlm_lock * dlm_new_lock(int type, > /* zero memory only if kernel-allocated */ > lksb = kzalloc(sizeof(*lksb), GFP_NOFS); > if (!lksb) { > - kfree(lock); > + kmem_cache_free(dlm_lock_cache, lock); > return NULL; > } > kernel_allocated = 1; > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Life's Little Instruction Book #43 "Never give up on somebody. Miracles happen every day." http://www.jlbec.org/ jlbec@xxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
