Ping, Greg? On Sat, Jul 30, 2011 at 2:01 PM, Mathias Krause <minipli@xxxxxxxxxxxxxx> wrote: > Even though this is valid C we should not mix C99 initializers with > obfuscated ANSI C. Stick to C99 and initialize c by its name. > > Found by clang: > drivers/tty/vt/vt.c:262:55: warning: explicitly assigning a variable of > type 'unsigned int' to itself [-Wself-assign] > struct vt_notifier_param param = { .vc = vc, unicode = unicode }; > ~~~~~~~ ^ ~~~~~~~ > > Signed-off-by: Mathias Krause <minipli@xxxxxxxxxxxxxx> > --- > drivers/tty/vt/vt.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c > index b3915b7..e716839 100644 > --- a/drivers/tty/vt/vt.c > +++ b/drivers/tty/vt/vt.c > @@ -259,7 +259,7 @@ EXPORT_SYMBOL_GPL(unregister_vt_notifier); > > static void notify_write(struct vc_data *vc, unsigned int unicode) > { > - struct vt_notifier_param param = { .vc = vc, unicode = unicode }; > + struct vt_notifier_param param = { .vc = vc, .c = unicode }; > atomic_notifier_call_chain(&vt_notifier_list, VT_WRITE, ¶m); > } > > -- > 1.5.6.5 -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html