On Sat, 2011-08-06 at 07:23 -0700, Dan Carpenter wrote:
> We always hit the goto and skip the printk(). The original code does
> the right thing even though it looks messy.
>
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
Acked-by: Dan Williams <dcbw@xxxxxxxxxx>
>
> diff --git a/drivers/net/wireless/libertas/if_spi.c b/drivers/net/wireless/libertas/if_spi.c
> index e0286cf..622ae6d 100644
> --- a/drivers/net/wireless/libertas/if_spi.c
> +++ b/drivers/net/wireless/libertas/if_spi.c
> @@ -531,10 +531,6 @@ static int if_spi_prog_helper_firmware(struct if_spi_card *card,
> goto out;
> err = spu_write_u16(card, IF_SPI_CARD_INT_CAUSE_REG,
> IF_SPI_CIC_CMD_DOWNLOAD_OVER);
> - goto out;
> -
> - lbs_deb_spi("waiting for helper to boot...\n");
> -
> out:
> if (err)
> pr_err("failed to load helper firmware (err=%d)\n", err);
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
