Am 04.08.2011 08:54, schrieb Nandigama, Nagalakshmi: > The patch seem to be fine. Please consider this patch as an Acked by me > > Regards, > Nagalakshmi Hi Nagalakshmi, nice try :) when you want to acknowledge a patch you should write: Acked-by: "Nandigama, Nagalakshmi" <Nagalakshmi.Nandigama@xxxxxxx> Otherwise scripts that look for an acknowledge have a hard time. re, wh > > > -----Original Message----- > From: Julia Lawall [mailto:julia@xxxxxxx] > Sent: Tuesday, August 02, 2011 4:05 PM > To: Moore, Eric; trivial@xxxxxxxxxx > Cc: kernel-janitors@xxxxxxxxxxxxxxx; Support; DL-MPT Fusion Linux; linux-scsi@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: [PATCH 2/11] drivers/message/fusion/mptsas.c: trivial: use BUG_ON > > From: Julia Lawall <julia@xxxxxxx> > > Use BUG_ON(x) rather than if(x) BUG(); > > The semantic patch that fixes this problem is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ identifier x; @@ > -if (x) BUG(); > +BUG_ON(x); > > @@ identifier x; @@ > -if (!x) BUG(); > +BUG_ON(!x); > // </smpl> > > Signed-off-by: Julia Lawall <julia@xxxxxxx> > > --- > drivers/message/fusion/mptsas.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff -u -p a/drivers/message/fusion/mptsas.c b/drivers/message/fusion/mptsas.c > --- a/drivers/message/fusion/mptsas.c > +++ b/drivers/message/fusion/mptsas.c > @@ -3410,8 +3410,7 @@ mptsas_expander_event_add(MPT_ADAPTER *i > __le64 sas_address; > > port_info = kzalloc(sizeof(struct mptsas_portinfo), GFP_KERNEL); > - if (!port_info) > - BUG(); > + BUG_ON(!port_info); > port_info->num_phys = (expander_data->NumPhys) ? > expander_data->NumPhys : 1; > port_info->phy_info = kcalloc(port_info->num_phys, > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
