From: Julia Lawall <julia@xxxxxxx> Use BUG_ON(x) rather than if(x) BUG(); The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier x; @@ -if (x) BUG(); +BUG_ON(x); @@ identifier x; @@ -if (!x) BUG(); +BUG_ON(!x); // </smpl> Signed-off-by: Julia Lawall <julia@xxxxxxx> --- drivers/iommu/iommu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff -u -p a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c --- a/drivers/iommu/iommu.c +++ b/drivers/iommu/iommu.c @@ -27,8 +27,7 @@ static struct iommu_ops *iommu_ops; void register_iommu(struct iommu_ops *ops) { - if (iommu_ops) - BUG(); + BUG_ON(iommu_ops); iommu_ops = ops; } -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
