On Wed, 2011-07-27 at 12:58 +0300, Dan Carpenter wrote: > The "goto out" path dereferences "login" which is NULL. > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> > > diff --git a/drivers/target/iscsi/iscsi_target_nego.c b/drivers/target/iscsi/iscsi_target_nego.c > index 713a4d2..4d087ac 100644 > --- a/drivers/target/iscsi/iscsi_target_nego.c > +++ b/drivers/target/iscsi/iscsi_target_nego.c > @@ -978,7 +978,7 @@ struct iscsi_login *iscsi_target_init_negotiation( > pr_err("Unable to allocate memory for struct iscsi_login.\n"); > iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_TARGET_ERR, > ISCSI_LOGIN_STATUS_NO_RESOURCES); > - goto out; > + return NULL; > } > > login->req = kzalloc(ISCSI_HDR_LEN, GFP_KERNEL); Thanks for catching this Dan! Committed as b5bddbe9e6 --nab -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html