Re: [patch] [media] pwc: precedence bug in pwc_init_controls()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Thanks I've added your patch to my gspca/pwc tree and
send an updated pull request to Mauro including your patch.

Regards,

Hans


On 07/23/2011 08:53 PM, Dan Carpenter wrote:
'!' has higher precedence than'&' so we need parenthesis here.

Signed-off-by: Dan Carpenter<error27@xxxxxxxxx>

diff --git a/drivers/media/video/pwc/pwc-v4l.c b/drivers/media/video/pwc/pwc-v4l.c
index e9a0e94..8c70e64 100644
--- a/drivers/media/video/pwc/pwc-v4l.c
+++ b/drivers/media/video/pwc/pwc-v4l.c
@@ -338,7 +338,7 @@ int pwc_init_controls(struct pwc_device *pdev)
  	if (pdev->restore_factory)
  		pdev->restore_factory->flags = V4L2_CTRL_FLAG_UPDATE;

-	if (!pdev->features&  FEATURE_MOTOR_PANTILT)
+	if (!(pdev->features&  FEATURE_MOTOR_PANTILT))
  		return hdl->error;

  	/* Motor pan / tilt / reset */
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux