On Wed, Jul 13 2011, Paul Mundt wrote: >> I wonder if the error handling code at the end of the function should be >> calling clk_put as well? In that case, having a separate label for this >> case would be useful. Otherwise, one of error_request_irq and error_get_clk >> can be deleted >> > The MSM implementation for it is simply a nop, so it's not going to > really matter one way or the other. In terms of general consistency it > might be worth implementing. Today, at least. Hopefully this will get better, since we can turn off our clocks. David -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html