On 06/15/2011 01:50 AM, Julia Lawall wrote: > On Tue, 14 Jun 2011, Brian King wrote: > >> On 06/09/2011 10:51 AM, Wayne Boyer wrote: >>> On 05/31/2011 07:16 AM, Julia Lawall wrote: >>>> From: Julia Lawall <julia@xxxxxxx> >>>> >>>> The out_msi_disable label should be before cleanup_nomem to additionally >>>> benefit from the call to iounmap. >>> >>> Yes, this is a problem. I propose the following patch instead. >> >> By removing the out_msi_disable label, if you fail initialization later >> on and goto cleanup_nomem, you will end up leaving MSI enabled when you exit >> with this patch. > > I agree. > > julia > I also agree. Please disregard my patch. -- Wayne Boyer IBM - Beaverton, Oregon LTC S/W Development (503) 578-5236, T/L 775-5236 -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
