On Mon, Jun 06, 2011 at 11:07:54PM +0200, Peter Huewe wrote:
> This patch replaces the code for getting an unsigned long from a
> userspace buffer by a simple call to kstroul_from_user.
> This makes it easier to read and less error prone.
>
> Kernel Version: v3.0-rc2
>
> Signed-off-by: Peter Huewe <peterhuewe@xxxxxx>
Acked-by: Jan Glauber <jang@xxxxxxxxxxxxxxxxxx>
> ---
> drivers/s390/cio/qdio_debug.c | 12 +++---------
> 1 files changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/s390/cio/qdio_debug.c b/drivers/s390/cio/qdio_debug.c
> index f8b03a6..0e615cb 100644
> --- a/drivers/s390/cio/qdio_debug.c
> +++ b/drivers/s390/cio/qdio_debug.c
> @@ -188,19 +188,13 @@ static ssize_t qperf_seq_write(struct file *file, const char __user *ubuf,
> struct qdio_irq *irq_ptr = seq->private;
> struct qdio_q *q;
> unsigned long val;
> - char buf[8];
> int ret, i;
>
> if (!irq_ptr)
> return 0;
> - if (count >= sizeof(buf))
> - return -EINVAL;
> - if (copy_from_user(&buf, ubuf, count))
> - return -EFAULT;
> - buf[count] = 0;
> -
> - ret = strict_strtoul(buf, 10, &val);
> - if (ret < 0)
> +
> + ret = kstrtoul_from_user(ubuf, count, 10, &val);
> + if (ret)
> return ret;
>
> switch (val) {
> --
> 1.7.3.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
