On Thu, 2 Jun 2011, Julia Lawall wrote: > From: Julia Lawall <julia@xxxxxxx> > > The label fail frees dev->buf, but kbuf hasn't yet been stored there at > this point. ... > Signed-off-by: Julia Lawall <julia@xxxxxxx> > > --- > I wonder if it is really correct to free dev->buf at fail in this case. > Because it is freeing the previously allocated value of dev->buf, not the > current one as done in subsequent cases. I don't think it matters. This check is probably there only for safety; it should not be possible for dev->buf to be non-NULL at this point. You ought to be able to remove the entire if (dev->buf) goto fail; statement with no ill effects. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
