On Sun, May 29, 2011 at 10:56:31PM +0300, Dan Carpenter wrote:
> "new_phys_cpos" is always a valid pointer here.
> ocfs2_probe_alloc_group() allocates "*new_phys_cpos".
>
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
This patch is now in the 'fixes' branch of ocfs2.git.
Joel
>
> diff --git a/fs/ocfs2/move_extents.c b/fs/ocfs2/move_extents.c
> index 4c54884..f3eb060 100644
> --- a/fs/ocfs2/move_extents.c
> +++ b/fs/ocfs2/move_extents.c
> @@ -747,7 +747,7 @@ static int ocfs2_move_extent(struct ocfs2_move_extents_context *context,
> */
> ocfs2_probe_alloc_group(inode, gd_bh, &goal_bit, len, move_max_hop,
> new_phys_cpos);
> - if (!new_phys_cpos) {
> + if (!*new_phys_cpos) {
> ret = -ENOSPC;
> goto out_commit;
> }
--
"If the human brain were so simple we could understand it, we would
be so simple that we could not."
- W. A. Clouston
http://www.jlbec.org/
jlbec@xxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
