On Fri, May 13, 2011 at 1:26 AM, Michal Marek <mmarek@xxxxxxx> wrote: > On 12.5.2011 23:38, matt mooney wrote: >> >> On Thu, May 12, 2011 at 2:20 PM, Michal Marek<mmarek@xxxxxxx> wrote: >>> >>> On 12.5.2011 23:07, matt mooney wrote: >>>> >>>> 2011/5/12 Michal Marek<mmarek@xxxxxxx>: >>>>> >>>>> Neither git archive not git rev-parse need the work tree, --git-dir=.. >>>>> is sufficient. >>>> >>>> Are you sure? >>> >>> Yes. >>> $ cd /tmp >>> $ git --git-dir=$HOME/linux-2.6/.git rev-parse HEAD >>> e0a04b11e4059cab033469617c2a3ce2d8cab416 >>> >> >> You are right about that command, but it doesn't use the source tree. > > Yes, neither git rev-parse nor git archive use the work tree. That's what I > tried to explain to you in my first mail. Okay, again you are right; I erroneously thought git archive needed the work tree too. >> Do a git --git-dir=$HOME/linux-2.6/.git status from /tmp and see what >> happens. > > That's irrelevant, I only talked about archive and rev-parse. > > >> So do you want me to send a new patch without --work-tree= in git >> rev-parse? > > And in git archive. So the real problem is that tools/perf/MANIFEST contains wildcards, and when git archive is run, file name expansion isn't working properly. By adding the $(srctree) as a prefix, globbing works but then git archive requires --work-tree to be set. I really don't know of a better alternative. Thanks, matt -- GPG-Key: 9AFE00EA -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
