On 03/29/2011 05:20 AM, Dan Carpenter wrote: > We checked "pdata" for NULL at the start of the function so we should > check it here as well. > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> Acked-by: Lars-Peter Clausen <lars@xxxxxxxxxx> > --- > Compile tested only. Please review. > > diff --git a/drivers/video/backlight/pcf50633-backlight.c b/drivers/video/backlight/pcf50633-backlight.c > index ef5628d..0fe934f 100644 > --- a/drivers/video/backlight/pcf50633-backlight.c > +++ b/drivers/video/backlight/pcf50633-backlight.c > @@ -136,7 +136,9 @@ static int __devinit pcf50633_bl_probe(struct platform_device *pdev) > > platform_set_drvdata(pdev, pcf_bl); > > - pcf50633_reg_write(pcf_bl->pcf, PCF50633_REG_LEDDIM, pdata->ramp_time); > + if (pdata) > + pcf50633_reg_write(pcf_bl->pcf, PCF50633_REG_LEDDIM, > + pdata->ramp_time); > > /* Should be different from bl_props.brightness, so we do not exit > * update_status early the first time it's called */ -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
