In this case I agree. Do you want me to move this patch up or you have your own path for it? Alex. -----Original Message----- From: Dan Carpenter [mailto:error27@xxxxxxxxx] Sent: Monday, March 21, 2011 11:00 AM To: Bounine, Alexandre Cc: Matt Porter; linux-kernel@xxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx Subject: Re: [patch] rapidio: potential null deref on failure path On Mon, Mar 21, 2011 at 05:49:06AM -0700, Bounine, Alexandre wrote: > Better to combine both conditions: > > if (rio_is_switch(rdev) && rswitch->route_table)) > kfree(rswitch->route_table); > > Because there is situation when routine fails to allocate route_table > for a switch. > kfree() accepts NULL pointers. People have been removing these checks all over the tree by the hundreds... Sorry I should have mentioned that. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
