On Tue, Mar 15, 2011 at 8:07 AM, Dan Carpenter <error27@xxxxxxxxx> wrote: > In the earlier check we assumed that "obj" could be NULL. ÂI looked at > some of the other places that call evaluate_object() and they check > for NULL as well. > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> > --- > Can obj actually be NULL here? ÂPerhaps a better fix would be to remove > the first check. Yes I think it can. > diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c > index a038595..efc776c 100644 > --- a/drivers/platform/x86/asus-wmi.c > +++ b/drivers/platform/x86/asus-wmi.c > @@ -1343,7 +1343,7 @@ static int show_call(struct seq_file *m, void *data) > Â Â Â Âelse > Â Â Â Â Â Â Â Âseq_printf(m, "%#x(%#x, %#x) = t:%d\n", asus->debug.method_id, > Â Â Â Â Â Â Â Â Â Â Â Â Â asus->debug.dev_id, asus->debug.ctrl_param, > - Â Â Â Â Â Â Â Â Â Â Â Â Âobj->type); > + Â Â Â Â Â Â Â Â Â Â Â Â Âobj ? obj->type : -1); Seems ok, I may change that later if we need to support more types. Acked-by: Corentin Chary <corentin.chary@xxxxxxxxx> -- Corentin Chary http://xf.iksaif.net -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
