On Sat, Feb 26, 2011 at 03:54:27PM +0300, Dan Carpenter wrote: > Sparse complains that these variables should be static. > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> Acked-by: Mattia Dongili <malattia@xxxxxxxx> > diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c > index a0ba0e7..a7b9c72 100644 > --- a/drivers/platform/x86/sony-laptop.c > +++ b/drivers/platform/x86/sony-laptop.c > @@ -745,7 +745,7 @@ struct sony_nc_handles { > struct device_attribute devattr; > }; > > -struct sony_nc_handles *handles; > +static struct sony_nc_handles *handles; > > static ssize_t sony_nc_handles_show(struct device *dev, > struct device_attribute *attr, char *buffer) > @@ -1358,7 +1358,7 @@ struct kbd_backlight { > struct device_attribute timeout_attr; > }; > > -struct kbd_backlight *kbdbl_handle; > +static struct kbd_backlight *kbdbl_handle; > > static ssize_t __sony_nc_kbd_backlight_mode_set(u8 value) > { -- mattia :wq! -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html