Re: [patch] watchdog: sch311x_wdt: fix printk condition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dan,

> "==" has higher precedence than "&".  Since
> if (sch311x_sio_inb(sio_config_port, 0x30) & (0x01 == 0)) is always
> false the message is never printed.
> 
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
> ---
> Btw, is this printk() even worth printing?

Patch will be added.
About the printk -> need to look into the data sheet for that... We might need to exit the driver or activate it or ...

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux