Julia Lawall <julia@xxxxxxx> writes: > Function _sr_lookup, defined in the same file, returns ERR_PTR not NULL in > an error case. Thanks, will queue this via the OMAP tree for 2.6.38-rc. Kevin > The semantic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @r@ > identifier f; > @@ > f(...) { ... return ERR_PTR(...); } > > @@ > identifier r.f, fld; > expression x; > statement S1,S2; > @@ > x = f(...) > ... when != IS_ERR(x) > ( > if (IS_ERR(x) ||...) S1 else S2 > | > *x->fld > ) > // </smpl> > > Signed-off-by: Julia Lawall <julia@xxxxxxx> > > --- > arch/arm/mach-omap2/smartreflex.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c > index 77ecebf..d7deadf 100644 > --- a/arch/arm/mach-omap2/smartreflex.c > +++ b/arch/arm/mach-omap2/smartreflex.c > @@ -966,7 +966,7 @@ static int __devexit omap_sr_remove(struct platform_device *pdev) > } > > sr_info = _sr_lookup(pdata->voltdm); > - if (!sr_info) { > + if (IS_ERR(sr_info)) { > dev_warn(&pdev->dev, "%s: omap_sr struct not found\n", > __func__); > return -EINVAL; > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
