On Thu, 20 Jan 2011 23:08:06 +0300, Vasiliy Kulikov wrote: > File position is not controlled, it may lead to overwrites of arbitrary > kernel memory. Also the code may kfree() the same pointer multiple > times. > > One more flaw is still present: if multiple processes open the file then > all 3 static variables are shared, leading to various race conditions. > They should be moved to file->private_data. > > Signed-off-by: Vasiliy Kulikov <segoon@xxxxxxxxxxxx> Reviewed-by: WANG Cong <xiyou.wangcong@xxxxxxxxx> Thanks. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html