Am 15.01.2011 17:54, schrieb Dan Carpenter: > On Sat, Jan 15, 2011 at 05:36:11PM +0100, walter harms wrote: >> >> >> Am 15.01.2011 15:04, schrieb Dan Carpenter: >>> The signed one-bit types can be 0 or -1 which can cause a problem if >>> someone ever checks if (foo->lu_gp_assoc == 1). The current code is >>> fine because everyone just checks zero vs non-zero. But Sparse >>> complains about it so lets change it. The warnings look like this: >>> >> >> Your code looks ok, >> but to avoid that kind of errors it may be better to use int here. >> > > I'm afraid I don't understand what you are saying. > IMHO, it is better to just drop the bitfield. Most people expect int as return. re, wh -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
