On Wed, Jan 12, 2011 at 08:05:10PM -0800, Sukanto Ghosh wrote: > > If you just set it to NULL, how could it ever not be NULL, so why add > > this check? > > > Because, there is an assignment to i inside the for-each loop (hlist_for_each) > if it enters the loop. Which it always will do, right? So there isn't a problem. > > Also, no, this isn't correct, i is used in the hlist traversal. > > > Indeed it is being used but what if it doesn't enters the loop i.e. if > h->first is NULL Can that ever happen? > It is a different issue whether (h->first != NULL) is a precondition > to this function I think it is as it works fine today :) > but the compiler is warning because there exists a path to access of i->head > where it might be left uninitialized. But again, that can never happen, right? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
