On Fri, Jan 07, 2011 at 08:12:27AM +0300, Dan Carpenter wrote: > This is a copy-and-paste bug. We should be comparing 4 characters here > instead of 3. > --- a/drivers/gpu/vga/vga_switcheroo.c > +++ b/drivers/gpu/vga/vga_switcheroo.c > @@ -346,11 +346,11 @@ vga_switcheroo_debugfs_write(struct file *filp, const char __user *ubuf, > if (strncmp(usercmd, "DIS", 3) == 0) > client_id = VGA_SWITCHEROO_DIS; > > - if (strncmp(usercmd, "MIGD", 3) == 0) { > + if (strncmp(usercmd, "MIGD", 4) == 0) { > just_mux = true; > client_id = VGA_SWITCHEROO_IGD; > } > - if (strncmp(usercmd, "MDIS", 3) == 0) { > + if (strncmp(usercmd, "MDIS", 4) == 0) { How about you NUL-terminate, and use strcmp(). -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html