On Mon, 2011-01-03 at 08:59 +0300, Dan Carpenter wrote:
> If the user wrote a wrong value to the file the it would lead to a dead
> lock eventually.
>
Good catch on this one. Commited as 827447968 and pushed into
lio-core-2.6.git.
Thanks!
--nab
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
>
> diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
> index d7b977d..2764510 100644
> --- a/drivers/target/target_core_configfs.c
> +++ b/drivers/target/target_core_configfs.c
> @@ -660,6 +660,7 @@ static ssize_t target_core_dev_store_attr_##_name( \
> } \
> ret = strict_strtoul(page, 0, &val); \
> if (ret < 0) { \
> + spin_unlock(&se_dev->se_dev_lock); \
> printk(KERN_ERR "strict_strtoul() failed with" \
> " ret: %d\n", ret); \
> return -EINVAL; \
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
