Looks good to me. > -----Original Message----- > From: Dan Carpenter [mailto:error27@xxxxxxxxx] > Sent: Sunday, January 02, 2011 11:49 PM > To: James E.J. Bottomley > Cc: Mike Snitzer; Menny Hamburger; Moger, Babu; linux- > scsi@xxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx > Subject: [patch] [SCSI] scsi_dh: potential null dereference in > scsi_dh_activate() > > We assumed "sdev" could be NULL ealier, so lets check it here as well. > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> > > diff --git a/drivers/scsi/device_handler/scsi_dh.c > b/drivers/scsi/device_handler/scsi_dh.c > index b837c5b..ff340e3 100644 > --- a/drivers/scsi/device_handler/scsi_dh.c > +++ b/drivers/scsi/device_handler/scsi_dh.c > @@ -446,7 +446,7 @@ int scsi_dh_activate(struct request_queue *q, > activate_complete fn, void *data) > sdev->sdev_state == SDEV_CANCEL || > sdev->sdev_state == SDEV_DEL) > err = SCSI_DH_NOSYS; > - if (sdev->sdev_state == SDEV_OFFLINE) > + if (sdev && sdev->sdev_state == SDEV_OFFLINE) > err = SCSI_DH_DEV_OFFLINED; > spin_unlock_irqrestore(q->queue_lock, flags); > -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
