On Fri, Dec 24, 2010 at 3:59 PM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote: > Subject: sched, cgroup: Use exit hook to avoid use-after-free crash > > By not notifying the controller of the on-exit move back to > init_css_set, we fail to move the task out of the previous cgroup's > cfs_rq. This leads to an opportunity for a cgroup-destroy to come in and > free the cgroup (there are no active tasks left in it after all) to > which the not-quite dead task is still enqueued. While this patch is likely fine for solving the problem, it does add extra work into the task exit path. Could you instead just use the pre_destroy callback to return -EBUSY if there are still any tasks on the cfs_rq? That way there'd only be a penalty on cgroup destruction, which is a much rarer operation. Paul -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
