Fri, Dec 24, 2010 at 06:17:34AM CET, error27@xxxxxxxxx wrote:
>The intent here was to test if the allocation failed but we tested
>"SharedMemSize" instead of "SharedMemAddr" by mistake.
>
>Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
>
>diff --git a/drivers/net/skfp/skfddi.c b/drivers/net/skfp/skfddi.c
>index 0a66fed..16c6265 100644
>--- a/drivers/net/skfp/skfddi.c
>+++ b/drivers/net/skfp/skfddi.c
>@@ -412,7 +412,7 @@ static int skfp_driver_init(struct net_device *dev)
> bp->SharedMemAddr = pci_alloc_consistent(&bp->pdev,
> bp->SharedMemSize,
> &bp->SharedMemDMA);
>- if (!bp->SharedMemSize) {
>+ if (!bp->SharedMemAddr) {
> printk("could not allocate mem for ");
> printk("hardware module: %ld byte\n",
> bp->SharedMemSize);
Looks obvious.
Reviewed-by: Jiri Pirko <jpirko@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
