Indeed, indeed. Thanks for catching that and fixing it!
>
> There were several paths that didn't release their locks.
>
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
Signed-off-by: Bhavesh Davda <bhavesh@xxxxxxxxxx>
>
> diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c
> b/drivers/net/vmxnet3/vmxnet3_drv.c
> index 23154cf..939e546 100644
> --- a/drivers/net/vmxnet3/vmxnet3_drv.c
> +++ b/drivers/net/vmxnet3/vmxnet3_drv.c
> @@ -980,7 +980,7 @@ vmxnet3_tq_xmit(struct sk_buff *skb, struct
> vmxnet3_tx_queue *tq,
> }
> } else {
> tq->stats.drop_hdr_inspect_err++;
> - goto drop_pkt;
> + goto unlock_drop_pkt;
> }
>
> /* fill tx descs related to addr & len */
> @@ -1052,6 +1052,8 @@ vmxnet3_tq_xmit(struct sk_buff *skb, struct
> vmxnet3_tx_queue *tq,
>
> hdr_too_big:
> tq->stats.drop_oversized_hdr++;
> +unlock_drop_pkt:
> + spin_unlock_irqrestore(&tq->tx_lock, flags);
> drop_pkt:
> tq->stats.drop_total++;
> dev_kfree_skb(skb);
> _______________________________________________
> Pv-drivers mailing list
> Pv-drivers@xxxxxxxxxx
> http://mailman2.vmware.com/mailman/listinfo/pv-drivers
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
