class_create() returns an ERR_PTR and it doesn't return NULL. Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> diff --git a/drivers/pps/pps.c b/drivers/pps/pps.c index ca5183b..ef88108 100644 --- a/drivers/pps/pps.c +++ b/drivers/pps/pps.c @@ -285,9 +285,9 @@ static int __init pps_init(void) int err; pps_class = class_create(THIS_MODULE, "pps"); - if (!pps_class) { + if (IS_ERR(pps_class)) { printk(KERN_ERR "pps: failed to allocate class\n"); - return -ENOMEM; + return PTR_ERR(pps_class); } pps_class->dev_attrs = pps_attrs; -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html