On Wed, Dec 08, 2010 at 03:56:09PM -0800, Roland Dreier wrote: > + tmp.port_num = wc->port_num; > + tmp.reserved = wc->port_num; I would probably have put a zero in tmp.reserved. Otherwise it looks good. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html