On Thu, Nov 25, 2010 at 08:35:52PM +0300, Dan Carpenter wrote:
> The break resets the retval to 0 but we want to return an error code.
> This was introduced in c64eefd48c4 "WMI: embed struct device directly
> into wmi_block"
>
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
>
Oops, thanks for finding it.
Acked-by: Dmitry Torokhov <dtor@xxxxxxx>
> diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c
> index 104b77c..a5b7a4d 100644
> --- a/drivers/platform/x86/wmi.c
> +++ b/drivers/platform/x86/wmi.c
> @@ -812,7 +812,7 @@ static acpi_status parse_wdg(acpi_handle handle)
> if (IS_ERR(wblock)) {
> retval = PTR_ERR(wblock);
> wmi_free_devices();
> - break;
> + goto out_free_pointer;
> }
>
> if (debug_event) {
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
